Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group-wise evaluation #12

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

naga-karthik
Copy link
Member

currently, the wrapper script compute_metrics_reloaded.py averages the results over all cases (i.e. when prediction and GT are empty, prediction empty GT not empty, etc. etc.).

When pred and GT are both empty, the DSC is set to 1 automatically (which is correct as the model has rightly learned to not output a false positive). BUT, a lot of these outputs, skews the DSC in such a way that we don't how the model performs in case where there is lesion (i.e. does it predict the whole lesion, does it predict only partially, etc.)

SO, for this, we want to separate the evalutation of results into two cases: (1) when GT is not Empty (and then average the resutls), (2) when the GT is empty, maybe compute the False Postive Rate.

credit to Julian McGinnis who started this discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant