Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description boxes smaller than 3 lines #3668

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fix description boxes smaller than 3 lines #3668

merged 1 commit into from
Mar 7, 2023

Conversation

amogusussy
Copy link
Contributor

If a video has no description, (without this commit) the description box will still take up 8.3em, even if there's no content in it.

This PR fixes that issue.

If a video has no description, (without this commit) the description box will still take up 8.3em, even if there's no content in it.

This fixes that issue.
@amogusussy amogusussy requested a review from a team as a code owner March 3, 2023 22:28
@amogusussy amogusussy requested review from unixfox and removed request for a team March 3, 2023 22:28
@amogusussy
Copy link
Contributor Author

Example without this PR:
https://i.imgur.com/F7BoIfw.png

With this PR:
https://imgur.com/5j55WAG.png

@pklion
Copy link

pklion commented Mar 4, 2023

I think it's caused by #3660 and it shouldn't be fixed with CSS, I suppose.

@SamantazFox
Copy link
Member

I think it's caused by #3660 and it shouldn't be fixed with CSS, I suppose.

Yes, this is indeed caused by #3660
for the record, here is a video that has actually no description: https://test.invidious.io/watch?v=iuevw6218F0

However, this fix can still be relevant for videos with a one or two lines description!

@pklion
Copy link

pklion commented Mar 4, 2023

However, this fix can still be relevant for videos with a one or two lines description!

I agree.

@SamantazFox SamantazFox changed the title Fix empty description boxes. Fix description boxes smaller than 3 lines Mar 7, 2023
@SamantazFox SamantazFox merged commit d79d6f3 into iv-org:master Mar 7, 2023
@SamantazFox
Copy link
Member

Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants