Rewrite parser for iv-org/documentation#76 #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn’t introduce breaking change for such a small thing. Just add a new field |
Member
Author
|
Considering this basically rewrites the entire parser I wouldn't exactly consider this PR to be a small change. |
|
I’m talking about the "country" object. Why don’t you add a new field instead of adding a breaking change and moving two fields? |
Member
Author
|
Fair enough. I've went ahead and unnested it along with the modified object in order to reflect iv-org/documentation#76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the parser to account for iv-org/documentation#76.
All new fields added by said PR has been added as well.
This PR also contains the code from #29.