-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Start work on Leaf support #3470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
preliminary Leaf support. Not yet tested or vetted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far looks good
I'm very much a noob when it comes to these things. How can I test this locally to make sure it works? I am far from being a coder or anything. Just a enthusiast prosumer |
Please take a look at the page I had sent and the ones near it If you're still stuck, I could take the PR the rest of the way. Just let me know. |
I have given it a shot on a dev VM to try and build a test environment, but docker is being stubborn. I don't want to derail your repo into a 'intro to docker development' thread. I would appreciate it if you (or anyone else) is able to test it out in a dev environment. I see there is a start-configuration that may need to be checked on as well. I will look at that script when I have some more free time pop up. |
Yes, you will need to add a TYPE entry to that script, as mentioned in the development guide. |
i updated the start-configuration. Wasn't too bad ;) |
Added small section for Leaf based on Mohist doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one line docs removal and it's good to merge.
Yea, I've been taking a look. My scripting skills are basically nonexistent. I understand what was done. I just can't write it. |
removed non-existent LEAF_DOWNLOAD_URL reference
I greatly appreciate you kickstarting the enhancement! |
preliminary Leaf support. Not yet tested or vetted.