Skip to content

Start work on Leaf support #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 1, 2025
Merged

Start work on Leaf support #3470

merged 6 commits into from
Jun 1, 2025

Conversation

gothickitty93
Copy link
Contributor

preliminary Leaf support. Not yet tested or vetted.

preliminary Leaf support. Not yet tested or vetted.
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looks good

@gothickitty93
Copy link
Contributor Author

I'm very much a noob when it comes to these things. How can I test this locally to make sure it works? I am far from being a coder or anything. Just a enthusiast prosumer

@itzg
Copy link
Owner

itzg commented May 30, 2025

Please take a look at the page I had sent and the ones near it

#3434 (comment)

If you're still stuck, I could take the PR the rest of the way. Just let me know.

@gothickitty93
Copy link
Contributor Author

I have given it a shot on a dev VM to try and build a test environment, but docker is being stubborn. I don't want to derail your repo into a 'intro to docker development' thread. I would appreciate it if you (or anyone else) is able to test it out in a dev environment.

I see there is a start-configuration that may need to be checked on as well. I will look at that script when I have some more free time pop up.

@itzg
Copy link
Owner

itzg commented May 31, 2025

I see there is a start-configuration that may need to be checked on as well. I will look at that script when I have some more free time pop up.

Yes, you will need to add a TYPE entry to that script, as mentioned in the development guide.

@gothickitty93
Copy link
Contributor Author

i updated the start-configuration. Wasn't too bad ;)

gothickitty93 and others added 2 commits June 1, 2025 16:05
Added small section for Leaf based on Mohist doc
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one line docs removal and it's good to merge.

@gothickitty93
Copy link
Contributor Author

Yea, I've been taking a look. My scripting skills are basically nonexistent. I understand what was done. I just can't write it.

removed non-existent LEAF_DOWNLOAD_URL reference
@itzg
Copy link
Owner

itzg commented Jun 1, 2025

Yea, I've been taking a look. My scripting skills are basically nonexistent. I understand what was done. I just can't write it.

I greatly appreciate you kickstarting the enhancement!

@itzg itzg linked an issue Jun 1, 2025 that may be closed by this pull request
@itzg itzg merged commit c11d2a0 into itzg:master Jun 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Leaf
2 participants