Repository navigation
Curseforge pack containing Cleanroom relauncher #4282
Description
Activity
I would have preferred you continued at the discussion you linked. I'm not sure why cleanroom is needed server side since their install section says it isn't needed
from https://github.com/Nomi-CEu/Nomi-CEu/wiki/Page-1:-Player-Information#32-cleanroom-installation
As far as Nomi-CEu, why can't you just install using this image's native CurseForge modpack support from https://www.curseforge.com/minecraft/modpacks/nomi-ceu
I would have preferred you continued at the discussion you linked.
I feel that the distinction between a discussion and a tracking issue is important here. Discussions are open-ended, vs this is a specific articulable goal.
I'm not sure why cleanroom is needed server side since their install section says it isn't needed
My functional requirement is server side performance. I noticed a difference, in particular a lack of stuttering, which I want on multiplayer. Java 25 is mega good compared to Java 8. And, current 1.12.2 distant horizons requires it as well.
Nomi-CEu
I don't know what "Nomi-CEu" is. My use case is a curse forge pack zip, which contains Cleanroom.
I don't know what "Nomi-CEu" is. My use case is a curse forge pack zip, which contains Cleanroom.
The discussion you referenced
Can you point to an example of a modpack that uses cleanroom?
I'm sorry, I didn't know anything about Cleanroom until quizzing Gemini about it. It's only been brought up in the discussion you linked so hadn't been on my radar.
Cleanroom handles modloader setup differently than standard Forge, so implementing support for it requires a bit of research.
Specifically, I'm pondering:
- Auto-Detection vs. Explicit Toggle: Evaluating whether I can reliably auto-detect Cleanroom requirement (e.g., via client-side relauncher mods in the pack) versus providing a clean, explicit configuration toggle (e.g.,
TYPE=CLEANROOMorUSE_CLEANROOM=true) so you have deterministic control. - Version Resolution: Investigating whether I can extract a specific Cleanroom version directly from the modpack’s bundled config files (like
config/relauncher.jsonorconfig/cleanroom_relauncher.cfg) versus accepting a user input parameter (e.g.,CLEANROOM_VERSION) that defaults to the latest GitHub release.
Do you have any preferences or advice on these setup approaches? Also, that specific example modpack that uses Cleanroom, will help to expedite my research and testing.
- Auto-Detection vs. Explicit Toggle: Evaluating whether I can reliably auto-detect Cleanroom requirement (e.g., via client-side relauncher mods in the pack) versus providing a clean, explicit configuration toggle (e.g.,
Oh and if anyone is interested in helping out, it'll actually be an enhancement over here
any preferences or advice
Not much unfortunately but I can help out with test cases.
Here's what an example profile looks like: Example Cleanroom Relauncher.zip
And here's the cfg file that relauncher generates on first startup:
$ cat config/relauncher.json { "latestVersion": "0.6.13-alpha", "targetJavaVersion": 0, "args": "", "autoSetup": false, "enableRelauncher": true, "fetchUpdates": true, "clearCleanroomFolder": false, "clearJavaProvisionFolder": false, "darkMode": false }
After going through the first time UI (and I selected a java arg):
{ "selectedVersion": "0.6.13-alpha", "latestVersion": "0.6.13-alpha", "targetJavaVersion": 25, "targetVendor": "Azul Zulu", "javaPath": "C:\\Users\\redacted\\.cleanroom\\java\\zulu25.36.205-ca-jdk25.0.4.1-win_x64\\zulu25.36.205-ca-jdk25.0.4.1-win_x64\\bin\\javaw.exe", "args": "-XX:+UseCompactObjectHeaders -XX:+UseZGC ", "autoSetup": true, "enableRelauncher": true, "fetchUpdates": true, "clearCleanroomFolder": false, "clearJavaProvisionFolder": false, "darkMode": false }
This may be relevant: https://cleanroommc.com/wiki/end-user-guide/installation/install-server
That server installation link helped; however, they didn't seem to clarify that Forge server needs to be installed first. Looking at https://github.com/itzg/docker-minecraft-server/blob/master/notes/start-script-flow.drawio.png I'll have this logic added in at the end of
start-finalSetupModpackwhen the modloader family has been identified as "forge".I'll also need to have that step swap out
SERVERwith thecleanroom-{version}-universal.jaras the entry point. I'm not going to mess with the "relauncher" part since this image already manages the automation and doesn't need and really doesn't work with an additional bootstrap phase.I'm afraid it might be a while before I can get to this. In fact, I probably need someone from the community to pick this up. I've got a day job and I'm trying to kick off my own business, so I'm very tight on spare time.
Enhancement Type
Improve an existing feature
Describe the enhancement
This is a issue extended from the discussion seen here: here. In particular:
This is blocking issue for me.
Consider adding a way of resolving a curseforge pack to a generic pack before the Cleanroom installer is used. Or, recommend a way that I can workaround this issue - I can spend the time to figure out how to convert a curseforge pack to a generic pack manually, but this is a pain, and it's surprising that this flow isn't supported since it is supported without cleanroom. thanks