Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muxer updates #9

Merged
merged 8 commits into from
May 27, 2024
Merged

Muxer updates #9

merged 8 commits into from
May 27, 2024

Conversation

patilyash19
Copy link
Collaborator

@patilyash19 patilyash19 commented May 16, 2024

Significance

  • Bug fixes for few of the parameters calculation
  • Bug fixes for mhaC box data in mp4 header.
  • Changed box alignment from 4 byte to 1 byte
  • Added support for mhaP, btrt, mhaD, maeG, maeP, maeS and maeL box
  • Fix for demuxer with mhm1 and mha1 file format
  • Memory optimisation based on level supported for muxer.
  • Code clean up

Testing

  • Test with mmtisobmff tool for box data
  • Test for mhm1 and mha1 mp4 file format with Ittiam MPEGH Decoder
  • Tested for demuxed mhas files with Ittiam MPEGH Decoder, output in line with mp4 test streams.

Significance
------------
- Bug fixes for few of the paramters calculation
- Bug for mhaC box data for mhm1 file format
- Changed box allignment from 4 byte to 1 byte
- Fixes for hard coding for box data
- Added support for mhaP, btrt, maeG, maeP, maeS and maeL box
- Code clean up

Testing
-------
- Test with mmtisobmff tool for box data
- Test for mhm1 and mha1 file format

To be done
----------
- Addition of mhaD box
- Memory usage based on supported profile
patilyash19 and others added 3 commits May 17, 2024 15:58
Significance
------------
- Fix for intermediate config packets for mhm1 file format and mha1 file
  format

Testing
-------
- Test with mmtisobmff tool for box data
- Test for mhm1 and mha1 file format
Significance
------------
- Added support for mhaD box

Testing
-------
- Test using ittiam MPEG-H decoder
- Test for mhm1 file format

To be done
----------
- Memory usage based on supported profile
Significance
------------
- Fix for mhm1 demuxing

Testing
-------
- Test using ittiam MPEG-H decoder
- Test for mhm1 file format
@SakethSathuvalli SakethSathuvalli self-requested a review May 24, 2024 17:11
uzairittiam and others added 3 commits May 25, 2024 13:11
Signficance
-----------
- Reduced memory size of 3da config and audio scene info structures

Testing
-------
- Tested with Ittiam MPEG-H decoder
- Tested for mhm1 file format
Signficance
-----------
- Addresed review comment related to freeing up of memory

Testing
-------
- None
Memory Optimisation

Significance
-----------
- Reduced memory size of 3da config and audio scene info structures

Testing
 -------
 - Tested with Ittiam MPEG-H decoder
 - Tested for mhm1 file format
Vamsi100858
Vamsi100858 previously approved these changes May 27, 2024
@SakethSathuvalli SakethSathuvalli merged commit 26404e6 into main May 27, 2024
@SakethSathuvalli SakethSathuvalli deleted the Muxer_updation branch May 27, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants