-
Notifications
You must be signed in to change notification settings - Fork 9
Switch to nalgebra for statically allocated vectors #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2023
With the considerations in #53 the |
g-bauer
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StaticMat
struct was always meant as a placeholder until a more performant alternative is available.nalgebra provides statically allocated vectors and matrices. It is well maintained, more feature complete, and more performant.
As a consequence the
derive
api is not possible for vectors anymore. In this PR it is replaced with more explicit functions for, e.g., gradients, Hessians and Jacobians. Of course, it is still possible to construct dual numbers from their real and dual parts.Some disadvantages
Overall, this should be an advantage with regard to the maintainability, though.