This repository was archived by the owner on Jan 24, 2021. It is now read-only.
Fix percent encoding #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Make a #define or some way for retrieving this so that it doesn't need to be a magic string in the unit test and can be reused.
Contributor
Author
|
personally not too worried about magic strings in a test context but here you go |
stringByAddingPercentEscapesUsingEncoding is not reliable http://simonwoodside.com/weblog/2009/4/22/how_to_really_url_encode/
Contributor
Author
|
@elliotchance @itsthejb anything else needed for this PR? |
Contributor
|
I think it's fine, but I don't have permission to merge it in ... sorry. |
Owner
|
Ah, more fun dipping into CF to do things that should Just Work™. Here's another: Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringByAddingPercentEscapesUsingEncoding is not reliable
http://simonwoodside.com/weblog/2009/4/22/how_to_really_url_encode/
how's it going? 🍸