6214 РодионовАА Лаб. 4 #432
Closed
+182
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
AvtoBBus
requested changes
Dec 19, 2025
Collaborator
AvtoBBus
left a comment
AvtoBBus
left a comment
There was a problem hiding this comment.
За отличный дизайн (и отсутствие ещё времени на исправления) закрою глаза на не полностью выполняемый БЭМ, поэтому замечания только по JS
Так же на сколько я заметил не была сдана 2-я лабораторная, точнее PR вы сами закрыли, в силу того что у вас 1-я лаба уже не в срок (да и 3-я тоже) я её приму как сданную не в срок, но одно из главных замечаний по ней:
parent1
|
|__ parent1__child
|
|__ parent1__child
|
|__ parent1__child
parent2
|
|__ parent2__child
|
|__ parent2__child
|
|__ parent2__child
parent3
|
|__ parent3__child
|
|__ parent3__child
|
|__ parent2__child <-- гость
Вот так именовать классы и дальше комбинацией селекторов задавать стили
script.js
Outdated
Comment on lines
3
to
5
| const resBox = document.getElementById('result'); | ||
|
|
||
| if (calcBtn) { |
Collaborator
There was a problem hiding this comment.
Наличие calcBtn вы проверяете, а если resBox не нашелся?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.