6212 ТрундуковАС Лаб.3 #353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxwrlld
requested changes
Dec 14, 2025
mxwrlld
left a comment
mxwrlld
left a comment
There was a problem hiding this comment.
В целом, хорошо!
- Добавьте адаптивности, например, с помощью медиа - запросов: пусть при просмотре с узких экранов мобильных устройств блок с фотографией и персональной информацией располагается вверху страницы, а блок
main-contentпод ним - Согласуйте имена классов с БЭМ. Напоминаю, соглсно БЭМ именуем классы по шаблону
имя-блока__имя-элемента_имя-модификатора. Подробнее тут и тут. Сейчас нет ни одного элемента, сплошные блоки. Например, логично сделать навыки элементами блокаskills, т.е.skills__itemвместоskill-tag.softстановится модификатором элемента навыка, т.е.skills__item_softи т.д.
mxwrlld
requested changes
Dec 18, 2025
mxwrlld
left a comment
mxwrlld
left a comment
There was a problem hiding this comment.
Кажется, это всё ещё не то что нужно
|
Зачтено! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Простите меня пожалуйста! Я закинул лабу в срок, коммит от 20 ноября, просто не создал новую ветку и пулл реквест!