Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#377: Optionally render details section in HTML report as expanded #385

Merged
merged 13 commits into from
Feb 16, 2024
Merged

#377: Optionally render details section in HTML report as expanded #385

merged 13 commits into from
Feb 16, 2024

Conversation

kaklakariada
Copy link
Contributor

Closes #377

redcatbear
redcatbear requested changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for 100% coverage!

I think the command line usage text file also needs to be adapted. That is sitting in a resource file somewhere.

api/src/main/java/org/itsallcode/openfasttrace/api/DetailsSectionFolding.java Outdated Show resolved Hide resolved
api/src/main/java/org/itsallcode/openfasttrace/api/DetailsSectionFolding.java Outdated Show resolved Hide resolved
api/src/main/java/org/itsallcode/openfasttrace/api/ReportSettings.java Outdated Show resolved Hide resolved
api/src/main/java/org/itsallcode/openfasttrace/api/ReportSettings.java Outdated Show resolved Hide resolved
api/src/main/java/org/itsallcode/openfasttrace/api/ReportSettings.java Outdated Show resolved Hide resolved
doc/spec/system_requirements.md Outdated Show resolved Hide resolved
doc/user_guide.md Outdated Show resolved Hide resolved
oft-self-trace.sh Outdated Show resolved Hide resolved
.../src/main/java/org/itsallcode/openfasttrace/report/html/view/html/HtmlSpecificationItem.java Outdated Show resolved Hide resolved
...r/html/src/main/java/org/itsallcode/openfasttrace/report/html/view/html/HtmlViewFactory.java Outdated Show resolved Hide resolved
redcatbear
redcatbear requested changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to update src/main/resources/usage.txt.

@kaklakariada kaklakariada changed the title #377: Optionally render details section in HTML report as open #377: Optionally render details section in HTML report as expanded Feb 16, 2024
@kaklakariada kaklakariada enabled auto-merge (squash) February 16, 2024 10:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kaklakariada kaklakariada merged commit 97b809a into main Feb 16, 2024
10 checks passed
@kaklakariada kaklakariada deleted the kaklakariada/issue377 branch February 16, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redcatbear redcatbear redcatbear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command line option to generate HTML report with expanded sections
2 participants
@kaklakariada @redcatbear