Skip to content

Conversation

Lamparter
Copy link
Contributor

image

As anyone can tell, NuGet hates inline HTML. So, I created a NuGet specific README that's more simplified and doesn't contain anything particularly special.

I also rewrote the existing README to make it look prettier. Enjoy!

Copy link
Owner

@itsWindows11 itsWindows11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are changes that must be implemented before I can merge this. Good work so far!

Copy link
Owner

@itsWindows11 itsWindows11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Lamparter and others added 3 commits October 5, 2024 14:05
Co-authored-by: SimpleBear <81253203+itsWindows11@users.noreply.github.com>
The Second Part.

Co-authored-by: SimpleBear <81253203+itsWindows11@users.noreply.github.com>
Co-authored-by: SimpleBear <81253203+itsWindows11@users.noreply.github.com>
@itsWindows11
Copy link
Owner

Any updates on the rest of the requested changes before I take over?

@Lamparter
Copy link
Contributor Author

Oops, sorry I forgot about this. I'll try do it soon...

@itsWindows11
Copy link
Owner

itsWindows11 commented Oct 12, 2024

lmao

@Lamparter
Copy link
Contributor Author

Lamparter commented Oct 12, 2024

Done!

image
You might also want to consider simplifying the CI name 🙂

@itsWindows11
Copy link
Owner

I thought about it but the title should explain what the action does in a comprehensive way, I could try to somehow separate the NuGet publishing logic from building and leave the building part in the README, but it's out of scope.

Copy link
Owner

@itsWindows11 itsWindows11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comments for additional changes.

Lamparter and others added 2 commits October 12, 2024 09:46
Co-authored-by: SimpleBear <81253203+itsWindows11@users.noreply.github.com>
Co-authored-by: SimpleBear <81253203+itsWindows11@users.noreply.github.com>
@itsWindows11 itsWindows11 merged commit b4cc2c9 into itsWindows11:main Oct 12, 2024
@Lamparter Lamparter deleted the better-branding branch October 12, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants