Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] porting from 10.0 to 11.0 #483

Merged
merged 8 commits into from
Nov 10, 2017
Merged

[PORT] porting from 10.0 to 11.0 #483

merged 8 commits into from
Nov 10, 2017

Conversation

GabbasovDinar
Copy link

No description provided.

yelizariev
yelizariev approved these changes Nov 9, 2017
View reviewed changes
Copy link
Collaborator

@yelizariev yelizariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is reviewed

@ilmir-k
Copy link
Contributor

ilmir-k commented Nov 9, 2017

@GabbasovDinar add test: true into https://github.com/it-projects-llc/pos-addons/blob/11.0/pos_order_cancel/static/src/js/tour.js

see for example https://github.com/it-projects-llc/pos-addons/blob/11.0/pos_disable_payment/static/src/js/tour.js

@yelizariev
Copy link
Collaborator

yelizariev commented Nov 9, 2017 •
edited
Loading

  • don't use _t for tests only tour

                   content: _t("<p>Click <b>table</b></p>"),

yelizariev
yelizariev requested changes Nov 9, 2017
View reviewed changes
Copy link
Collaborator

@yelizariev yelizariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use _t for tests only tour

ilmir-k
ilmir-k approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@ilmir-k ilmir-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be merged

@yelizariev yelizariev merged commit 7dfbf9f into itpp-labs:11.0 Nov 10, 2017
KolushovAlexandr pushed a commit to KolushovAlexandr/pos-addons that referenced this pull request Sep 30, 2019
Merge pull request itpp-labs#483 from yelizariev/pos-addons-11.0-pos-…
825f420 
…qr-payments-docs

Pos addons 11.0 pos qr payments docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilmir-k ilmir-k ilmir-k approved these changes

@yelizariev yelizariev yelizariev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GabbasovDinar @ilmir-k @yelizariev