Skip to content

feat: upgrade dependencies to use Java 17 and jakarta #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deniszmihaj
Copy link

I upgraded some Dependencies to be able to build and run this Application with Java 17 and Jakarta Classes.

@pie-ai
Copy link

pie-ai commented Oct 2, 2024

As a heavy user of the validator, we embed the jar as a dependency. As the infrastructure partly runs on a java 11 stack, these code changes would make it impossible to ship it the current way. It would be great to have multiple target runtimes with that switch the jakarta/javax dependencies and different target java versions instead of replacing the current one.

@deniszmihaj
Copy link
Author

Are you using Version 1.5.0 normaly?

@pie-ai
Copy link

pie-ai commented Nov 8, 2024

Sorry, I was totally confused by all the components of eforms. We are not using it, no issue with that!

@xxxyyyz xxxyyyz mentioned this pull request Apr 10, 2025
@xxxyyyz
Copy link

xxxyyyz commented Apr 10, 2025

@deniszmihaj would you mind updating the configuration of maven-resource-plugin according to #163, i.e. setting the propertiesEncoding to ISO-8859-1?

I'm planning to base our local build on your branch, so it would be helpful if maven build runs without any further modification.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants