Fix flowtype of date object in ReadDirItem #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also upgrades flow bin to match .flowconfig version and adds a npm script to run flow check.
|
Thanks for contributing! Please consider that created/modified was renamed to mtime/ctime in order to be compatible with result of stat()-function (although it wasnt reflected right in ReadDirItem). I changed this in ReadDirItem after the merge. |
|
When this change will be released? |
|
I am currently adding some further methods and will release today apparently |
|
Thanks! Looking forward to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On react-native projects that use flow (on by default), this started showing up as an invalid type.
This commit also upgrades flow bin to match .flowconfig version and adds a npm script to run flow check.
Resolves #289
Test plan
npm run flow, no longer see error for undefineddatetype.