`writeFile` and `appendFile` take iOS specific file attributes

[cjdell]

The attributes parameter is passed directly to createFileAtPath and is a legacy dating back to when this library was only available on iOS. A standard abstraction for both iOS and Android should be made.

[johanneslumpe]

👍

[cjdell]

attributes argument has been removed from writeFile and appendFile, but I realise no alternative way of setting attributes exists just yet. It may be impossible to find a suitable abstraction for both platforms. I'm thinking maybe there should be a separate platform specific method just for setting attributes for people who really need them.

i.e. setIosAttributes(filepath: string, attributes: object)

[johanneslumpe]

@cjdell wouldn't that put quite a burden onto the users of the lib? If there are equivalent attributes for Android and iOS, maybe we should abstract them away for the users and create a generic wrapper? Why do you think it may be impossible to find a suitable abstraction?

[cjdell]

@johanneslumpe These are all the keys that could previously be set in the attributes hash:

NSString * const NSFileType;
NSString * const NSFileSize;
NSString * const NSFileModificationDate;
NSString * const NSFileReferenceCount;
NSString * const NSFileDeviceIdentifier;
NSString * const NSFileOwnerAccountName;
NSString * const NSFileGroupOwnerAccountName;
NSString * const NSFilePosixPermissions;
NSString * const NSFileSystemNumber;
NSString * const NSFileSystemFileNumber;
NSString * const NSFileExtensionHidden;
NSString * const NSFileHFSCreatorCode;
NSString * const NSFileHFSTypeCode;
NSString * const NSFileImmutable;
NSString * const NSFileAppendOnly;
NSString * const NSFileCreationDate;
NSString * const NSFileOwnerAccountID;
NSString * const NSFileGroupOwnerAccountID;
NSString * const NSFileBusy;

Perhaps we should only support a subset of them? Since you originally introduced the feature, do you remember which attributes you needed to be able to set? I imagine only a very small number of them will be used in practise.

[johanneslumpe]

@cjdell I really do not remember haha. I originally wrote the library for fun, not because i actually needed it. Someone was asking for it and I had nothing better to do ;) I think we should see which of those have a matching attribute on Android and then go with that subset. We might be able to support others using OS-specific methods, but it would be great to have at least a cross-platform subset working.