Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set X-Frame-Options in netlify config #779

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

brentswisher
Copy link
Contributor

@brentswisher brentswisher commented Jul 19, 2024

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
Sets the X-Frame-Options to allow storybook to load iframes

Additional context
Followup to #778

@brentswisher brentswisher requested a review from a team as a code owner July 19, 2024 13:40
@brentswisher brentswisher requested review from daneah, sirrah-tam and mtorres3 and removed request for a team July 19, 2024 13:40
@brentswisher brentswisher self-assigned this Jul 19, 2024
Copy link

changeset-bot bot commented Jul 19, 2024

⚠️ No Changeset found

Latest commit: 0f886b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/pharos/lib/index.js 64.73 KB (0%)

@brentswisher brentswisher merged commit a8e4b8a into develop Jul 19, 2024
7 checks passed
@brentswisher brentswisher deleted the fix/storybook-x-frame-options branch July 19, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants