fix(tabs): allow scrolling the panel contents #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-iden
requested review from
sirrah-tam,
jialin-he and
mtorres3
and removed request for
a team
🦋 Changeset detectedLatest commit: d60bf97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
shoupeva-ithaka
approved these changes
May 28, 2024
ymouzakis
approved these changes
May 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
This allows the tabs panel contents to scroll if there is a height defined on the parent element in the DOM
How does this change work?
Give the height: 100% so the browser can compute overflow behavior where applicable
Here is a video where I apply the fix to a few different contexts we use tabs to show it fixes the old behavior we had in pharos 13 without affecting the new behavior we added in pharos 14 release
https://github.com/ithaka/pharos/assets/13315416/acb679a9-6d06-4c53-a49c-78576c69788a
Additional context
Closes #760