Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: fix the empty table column cell element and add test #726

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

sirrah-tam
Copy link
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
Resolves #724

Adds test to confirm that table that has an empty column header adds an empty table cell.

How does this change work?
Updates the <tb></tb> to <td></td>

@sirrah-tam sirrah-tam requested a review from a team as a code owner March 15, 2024 16:27
@sirrah-tam sirrah-tam requested review from daneah, brentswisher and jialin-he and removed request for a team March 15, 2024 16:27
Copy link

changeset-bot bot commented Mar 15, 2024

🦋 Changeset detected

Latest commit: db1b2a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/pharos/lib/index.js 63.74 KB (-0.15% 🔽)

@sirrah-tam sirrah-tam merged commit 72e9476 into develop Mar 15, 2024
7 checks passed
@sirrah-tam sirrah-tam deleted the fix/empty-table-header branch March 15, 2024 17:28
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table empty column header incorrect element
3 participants