Possible redundant reset `HandlerCfg`

[0xurb]

Not sure also about that

odyssey/crates/node/src/evm.rs

Lines 145 to 146 in 811f874

	cfg_env.handler_cfg.spec_id = spec_id;
	cfg_env.handler_cfg.is_optimism = true;

Because, Odyssey's evm used reth's trait ConfigureEvm with .optimism(). So, we are set spec id here and is_optimism = true on ConfigureEvm::evm (via optimism register handler) than do it again via ConfigureEvmEnv::fill_cfg_and_block_env?

[onbjerg]

I don't follow, can you rephrase?

[0xurb]

For sure. On Evm configuration we are setup evm builder with .optimism() here:

odyssey/crates/node/src/evm.rs

Lines 222 to 234 in 811f874

	impl ConfigureEvm for OdysseyEvmConfig {
	type DefaultExternalContext<'a> = ();
	fn evm<DB: Database>(&self, db: DB) -> Evm<'_, Self::DefaultExternalContext<'_>, DB> {
	EvmBuilder::default()
	.with_db(db)
	.optimism()
	// add additional precompiles
	.append_handler_register(Self::set_precompiles)
	.build()
	}

That means we are modifying handler config with:

    /// Handler for optimism
    #[cfg(feature = "optimism")]
    pub fn optimism<SPEC: Spec>() -> Self {
        let mut handler = Self::mainnet::<SPEC>();
        handler.cfg.is_optimism = true;
        handler.append_handler_register(HandleRegisters::Plain(
            crate::optimism::optimism_handle_register::<DB, EXT>,
        ));
        handler
    }

Usage in reth for example here
https://github.com/paradigmxyz/reth/blob/c4d7b591834055bdf3afed96b696e0a2cef0f383/crates/optimism/evm/src/execute.rs#L276-L288

Question: do we need to do below, as we are already set that by calling .optimism():

odyssey/crates/node/src/evm.rs

Lines 145 to 146 in 811f874

	cfg_env.handler_cfg.spec_id = spec_id;
	cfg_env.handler_cfg.is_optimism = true;

[onbjerg]

got it, you're correct

[0xurb]

Then same on reth revm optimism