Parameterisation of p' and ff' profiles #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBlokhuizen
requested review from
maarten-ic and
MireilleSchneider
as code owners
|
Would be nice to add an explanation (e.g. equation) showing how p' and ff' are parameterised using alpha, beta, gamma. |
Indeed! As I understand it, p' and ff' are parametrized by NICE in the same way as equation 2.11 in https://inria.hal.science/hal-01088772/file/CedresRefPaper.pdf, but we need to double-check. We also need some changes in NICE (right now the inverse mode IMAS run modes do not seem to accept parametrized p' and ff'), so we've put this PR on hold for now. |
maarten-ic
reviewed
Aug 20, 2025
maarten-ic
reviewed
Aug 26, 2025
| self.properties_params.f_df_dpsi_beta, | ||
| self.properties_params.f_df_dpsi_gamma, | ||
| alpha = self.properties_params.alpha | ||
| beta = self.properties_params.beta |
There was a problem hiding this comment.
Do we need this many? A couple 10s of points should be enough, shouldn't it?
Co-authored-by: Maarten Sebregts <110895564+maarten-ic@users.noreply.github.com>
maarten-ic
reviewed
Aug 28, 2025
Co-authored-by: Maarten Sebregts <110895564+maarten-ic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlasmaPropertiesnow supports manual input. The p' and ff' profiles can be parameterized using alpha, beta, and gamma parameters.Screencast.from.2025-08-14.15-25-38.webm