Skip to content

Fix training assets #105

Merged
olivhoenen merged 4 commits intoiterorganization:developfrom
olivhoenen:fix/training_assets
Feb 27, 2026
Merged

Fix training assets #105
olivhoenen merged 4 commits intoiterorganization:developfrom
olivhoenen:fix/training_assets

Conversation

@olivhoenen
Copy link
Collaborator

The equilibrium had one inconsistent coordinate size (empty but allocated grids_ggd), this is now fixed.
By consequence I've removed the disabling of coord checks in the training data load function, and took this opportunity to allow loading the data in its original version (avoids missing quantities due to DD4 conversion otherwise).


def get_training_db_entry() -> imas.DBEntry:
"""Open and return an ``imas.DBEntry`` pointing to the training data."""
def get_training_db_entry(convert=False) -> imas.DBEntry:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with changing the default from convert to do-not-convert, however there's a couple of tests failing now that seem to need convert=True.

Copy link
Collaborator Author

@olivhoenen olivhoenen Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I hesitated but I'll fix the tests then because I would prefer that the default training examples do not come with messages about missing quantities, DD conversion aspects shall come at a later stage for newcomers IMO.

olivhoenen and others added 2 commits February 27, 2026 14:19
Co-authored-by: Maarten Sebregts <110895564+maarten-ic@users.noreply.github.com>
@olivhoenen olivhoenen merged commit 6d03d68 into iterorganization:develop Feb 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants