Skip to content

show meaningfull error message when MDSPLUS_MODELS_PATH is not set #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonPinches merged 1 commit into from
Apr 15, 2026
+23 −2
Merged

show meaningfull error message when MDSPLUS_MODELS_PATH is not set #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/mdsplus/mdsplus_backend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4496,7 +4496,12 @@ std::string MDSplusBackend::getTimedNode(ArraystructContext *ctx, std::string fu
} catch(MDSplus::MdsException &exc) {
if (mode!=alconst::force_open_pulse) {
resetIdsPath(szTree);
throw ALBackendException(exc.what()+mdsplusBaseStr,LOG);
std::string hint;
const char *modelsPath = getenv("MDSPLUS_MODELS_PATH");
if (!modelsPath || !*modelsPath) {
hint = " -- MDSPLUS_MODELS_PATH is not set; set it to the MDSplus models directory (e.g. export MDSPLUS_MODELS_PATH=/path/to/models/mdsplus)";
}
throw ALBackendException(exc.what()+mdsplusBaseStr+hint,LOG);
}
}
case alconst::create_pulse:
Expand All @@ -4509,6 +4514,17 @@ std::string MDSplusBackend::getTimedNode(ArraystructContext *ctx, std::string fu
} catch (const std::exception& exc) {
throw ALBackendException("Unable to create data-entry directory: "+mdsplusBaseStr,LOG);
}
{
const char *modelsPath = getenv("MDSPLUS_MODELS_PATH");
if (!modelsPath || !*modelsPath) {
resetIdsPath(szTree);
throw ALBackendException(
std::string("MDSPLUS_MODELS_PATH is not set. Set it to the MDSplus models directory "
"(e.g. export MDSPLUS_MODELS_PATH=/path/to/models/mdsplus) "
"before creating a pulse file."),
LOG);
}
}
try {
MDSplus::Tree *modelTree = new MDSplus::Tree(szTree, -1, DEF_READONLYMODE);
modelTree->createPulse(shotNum);
Expand All @@ -4517,7 +4533,12 @@ std::string MDSplusBackend::getTimedNode(ArraystructContext *ctx, std::string fu
saveVersion(tree);
} catch(MDSplus::MdsException &exc) {
resetIdsPath(szTree);
throw ALBackendException(exc.what()+mdsplusBaseStr,LOG);
std::string hint;
const char *modelsPath = getenv("MDSPLUS_MODELS_PATH");
if (!modelsPath || !*modelsPath) {
hint = " -- MDSPLUS_MODELS_PATH is not set; set it to the MDSplus models directory (e.g. export MDSPLUS_MODELS_PATH=/path/to/models/mdsplus)";
}
throw ALBackendException(exc.what()+mdsplusBaseStr+hint,LOG);
}
break;
default:
Expand Down
Loading