Skip to content

build MDSPLUS models based on imas_data_dictionary pypi package #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prasad-sawantdesai wants to merge 2 commits into
base: develop
Choose a base branch
from
+103 −43
Open

build MDSPLUS models based on imas_data_dictionary pypi package #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d0b3f0
build MDSPLUS models based on imas_data_dictionary pypi package
prasad-sawantdesai Apr 10, 2026
f990d5e
reverted changes about MACOS
prasad-sawantdesai Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ option(AL_BACKEND_MDSPLUS "Build the MDSplus backend" OFF)
option(AL_BACKEND_HDF5 "Build the HDF5 backend" ON)
option(AL_BACKEND_UDA "Build the UDA backend" OFF)
option(AL_BACKEND_UDAFAT "Build the UDA backend (use FAT UDA)" OFF)
include(CMakeDependentOption)
cmake_dependent_option(AL_BUILD_MDSPLUS_MODELS "Build MDSplus models" ON
AL_BACKEND_MDSPLUS OFF)
# User can build MDSPLUS models without having AL_BACKEND_MDSPLUS enabled
option(AL_BUILD_MDSPLUS_MODELS "Build MDSplus models" OFF)

# Configuration options for python bindings
# ##############################################################################
Expand Down Expand Up @@ -123,6 +122,9 @@ if(WIN32)
find_package(dlfcn-win32 CONFIG REQUIRED)
endif()

# build AL_CORE library only if backend is enabled
if(AL_BACKEND_HDF5 OR AL_BACKEND_MDSPLUS OR AL_BACKEND_UDA OR AL_BACKEND_UDAFAT OR AL_PYTHON_BINDINGS)

# Core dependencies
set(Boost_USE_MULTITHREADED FALSE)
find_package(
Expand Down Expand Up @@ -239,6 +241,8 @@ if(AL_PYTHON_BINDINGS)
include(skbuild.cmake)
endif()

endif() # AL core library (AL_BACKEND_HDF5 OR AL_BACKEND_MDSPLUS OR AL_BACKEND_UDA OR AL_BACKEND_UDAFAT OR AL_PYTHON_BINDINGS)


# MDSplus models
# ##############################################################################
Expand Down
136 changes: 96 additions & 40 deletions common/cmake/ALBuildDataDictionary.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,63 +38,119 @@ else()
endif()

if( NOT AL_DOWNLOAD_DEPENDENCIES AND NOT AL_DEVELOPMENT_LAYOUT )
# The DD easybuild module should be loaded, use that module:
# Create Python venv first and install imas_data_dictionary
# Check if imas_data_dictionary is already available in the current Python environment
execute_process(
COMMAND ${PYTHON_EXECUTABLE} -c "import imas_data_dictionary"
RESULT_VARIABLE _IDD_IMPORT_RESULT
OUTPUT_QUIET
ERROR_QUIET
)

if(NOT EXISTS "${_VENV_PYTHON}")
execute_process(
COMMAND ${PYTHON_EXECUTABLE} -m venv dd_build_env
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
RESULT_VARIABLE _VENV_EXITCODE
OUTPUT_VARIABLE _VENV_OUTPUT
ERROR_VARIABLE _VENV_ERROR
)

if(_IDD_IMPORT_RESULT)
# if not available in the current environment create a dd_build_env and pip-install it
execute_process(
COMMAND ${PYTHON_EXECUTABLE} -m venv dd_build_env
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
RESULT_VARIABLE _VENV_EXITCODE
OUTPUT_VARIABLE _VENV_OUTPUT
ERROR_VARIABLE _VENV_ERROR
)
else()
# IMAS-Data-Dictioanry is already available, just create environment for saxonche by pulling site packages
execute_process(
COMMAND ${PYTHON_EXECUTABLE} -m venv --system-site-packages dd_build_env
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
RESULT_VARIABLE _VENV_EXITCODE
OUTPUT_VARIABLE _VENV_OUTPUT
ERROR_VARIABLE _VENV_ERROR
)
endif()

if(_VENV_EXITCODE)
message(STATUS "venv stdout: ${_VENV_OUTPUT}")
message(STATUS "venv stderr: ${_VENV_ERROR}")
message(FATAL_ERROR "Failed to create venv (exit code: ${_VENV_EXITCODE}). Ensure Python has venv module installed: python -m venv --help")
endif()

if(DEFINED DD_VERSION)

if(_IDD_IMPORT_RESULT)
# pip-install imas_data_dictionary only when not already present.
if(DEFINED DD_VERSION AND DD_VERSION MATCHES "^[0-9]")
message(STATUS "Installing imas_data_dictionary==${DD_VERSION} from PyPI")
execute_process(
COMMAND ${_VENV_PIP} install imas_data_dictionary==${DD_VERSION}
RESULT_VARIABLE _PIP_EXITCODE
OUTPUT_VARIABLE _PIP_OUTPUT
ERROR_VARIABLE _PIP_ERROR
)
else()
if(DEFINED DD_VERSION AND NOT DD_VERSION STREQUAL "")
message(WARNING
"DD_VERSION='${DD_VERSION}' looks like a git ref which can be used when AL_DOWNLOAD_DEPENDECY=OFF. "
"Installing the latest imas_data_dictionary from PyPI. "
"Pass a numeric version (e.g. -DDD_VERSION=4.1.0) to use a specific release.")
else()
message(WARNING
"DD_VERSION is not set. Installing the latest imas_data_dictionary from PyPI. "
"Pass -DDD_VERSION=<x.y.z> to use a specific release.")
endif()
execute_process(
COMMAND ${_VENV_PIP} install imas_data_dictionary
RESULT_VARIABLE _PIP_EXITCODE
OUTPUT_VARIABLE _PIP_OUTPUT
ERROR_VARIABLE _PIP_ERROR
)
endif()

if(_PIP_EXITCODE)
message(STATUS "imas_data_dictionary pip output: ${_PIP_OUTPUT}")
message(STATUS "imas_data_dictionary pip error: ${_PIP_ERROR}")
message(FATAL_ERROR "Failed to install imas_data_dictionary dependency (exit code: ${_PIP_EXITCODE}). Check network connectivity and Python wheel compatibility.")
endif()

# Report which version was actually installed
execute_process(
COMMAND ${_VENV_PIP} install imas_data_dictionary==${DD_VERSION}
RESULT_VARIABLE _PIP_EXITCODE
OUTPUT_VARIABLE _PIP_OUTPUT
ERROR_VARIABLE _PIP_ERROR
COMMAND ${_VENV_PYTHON} -c
"import importlib.metadata; print(importlib.metadata.version('imas_data_dictionary'))"
OUTPUT_VARIABLE _IDD_INSTALLED_VERSION
OUTPUT_STRIP_TRAILING_WHITESPACE
ERROR_QUIET
)
else()
if(_IDD_INSTALLED_VERSION)
message(STATUS "Using imas_data_dictionary version ${_IDD_INSTALLED_VERSION}")
endif()
endif()

execute_process(
COMMAND ${_VENV_PYTHON} -c "import saxonche"
RESULT_VARIABLE _SAXONCHE_CHECK
OUTPUT_QUIET
ERROR_QUIET
)
if(_SAXONCHE_CHECK)
execute_process(
COMMAND ${_VENV_PIP} install imas_data_dictionary
COMMAND ${_VENV_PYTHON} -m pip install saxonche
RESULT_VARIABLE _PIP_EXITCODE
OUTPUT_VARIABLE _PIP_OUTPUT
ERROR_VARIABLE _PIP_ERROR
)
endif()

if(_PIP_EXITCODE)
message(STATUS "imas_data_dictionary pip output: ${_PIP_OUTPUT}")
message(STATUS "imas_data_dictionary pip error: ${_PIP_ERROR}")
message(FATAL_ERROR "Failed to install imas_data_dictionary dependency (exit code: ${_PIP_EXITCODE}). Check network connectivity and Python wheel compatibility.")
endif()

execute_process(
COMMAND ${_VENV_PIP} install saxonche
RESULT_VARIABLE _PIP_EXITCODE
OUTPUT_VARIABLE _PIP_OUTPUT
ERROR_VARIABLE _PIP_ERROR
)

if(_PIP_EXITCODE)
message(STATUS "saxonche pip output: ${_PIP_OUTPUT}")
message(STATUS "saxonche pip error: ${_PIP_ERROR}")
message(FATAL_ERROR "Failed to install saxonche dependency (exit code: ${_PIP_EXITCODE}). Check network connectivity and Python wheel compatibility.")

if(_PIP_EXITCODE)
message(STATUS "saxonche pip output: ${_PIP_OUTPUT}")
message(STATUS "saxonche pip error: ${_PIP_ERROR}")
message(FATAL_ERROR "Failed to install saxonche dependency (exit code: ${_PIP_EXITCODE}). Check network connectivity and Python wheel compatibility.")
endif()
endif()
endif()
# Set up idsinfo command path
if(WIN32)
set(_IDSINFO_COMMAND "${CMAKE_CURRENT_BINARY_DIR}/dd_build_env/Scripts/idsinfo.exe")
if(_IDD_IMPORT_RESULT)
if(WIN32)
set(_IDSINFO_COMMAND "${CMAKE_CURRENT_BINARY_DIR}/dd_build_env/Scripts/idsinfo.exe")
Comment thread
prasad-sawantdesai marked this conversation as resolved.
else()
set(_IDSINFO_COMMAND "${CMAKE_CURRENT_BINARY_DIR}/dd_build_env/bin/idsinfo")
endif()
else()
set(_IDSINFO_COMMAND "${CMAKE_CURRENT_BINARY_DIR}/dd_build_env/bin/idsinfo")
find_program(_IDSINFO_COMMAND NAMES idsinfo REQUIRED)
endif()

# Use idsinfo idspath command from venv to get the path to IDSDef.xml or data_dictionary.xml
Expand Down
Loading