Plot tooltip for truncated titles #4858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroy3
commented
Oct 18, 2023
extension/src/plots/vega/util.ts
Outdated
| @@ -262,11 +262,23 @@ export const truncateVerticalTitle = ( | |||
| const isEndValue = (valueType: string) => | |||
| ['string', 'number', 'boolean'].includes(valueType) | |||
|
|
|||
| type SpecTitle = { | |||
There was a problem hiding this comment.
This could be removed if we always showed everything in the tooltip
added 3 commits
October 19, 2023 12:35
mattseddon
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Nice.
If you look at #4734 most of this logic gets deleted. I'll have to move the tooltip creation to the webview when I get back to it 🙏🏻.
|
Code Climate has analyzed commit 984aae4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 97.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
Screen.Recording.2023-10-18.at.10.15.13.AM.mov
I'm unsure whether the tooltip should contain the whole thing every time and be there on every plot or not. That would certainly make the code simpler if we removed the part of the code that checks whether or not it is truncated.