Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group table styles #3667

Merged
merged 9 commits into from
Apr 19, 2023
Merged

Group table styles #3667

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6440c5c
Group general table styles
julieg18 Apr 11, 2023
d7faaab
Move body selector
julieg18 Apr 12, 2023
06e3d34
Add missing selector
julieg18 Apr 12, 2023
fa5b8eb
move indicators
julieg18 Apr 12, 2023
0c1568e
Clean up table head styles (#3674)
julieg18 Apr 19, 2023
7dc88c2
Merge branch 'main' into group-general-table-styles
julieg18 Apr 19, 2023
a5afcbb
Merge branch 'main' into group-general-table-styles
julieg18 Apr 19, 2023
3c19dbb
Fix typo
julieg18 Apr 19, 2023
63f0b22
Merge branch 'main' into group-general-table-styles
julieg18 Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move indicators
  • Loading branch information
@julieg18
julieg18 committed Apr 12, 2023
commit fa5b8eb49ccabb77e87290162e9e12206cf035f2
79 changes: 38 additions & 41 deletions webview/src/experiments/components/table/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ $edge-padding: 0.8rem;
$cell-padding: 0.5rem;
$workspace-row-edge-margin: $edge-padding - $cell-padding;
$bullet-size: calc(var(--design-unit) * 4px);
$badge-size: 0.85rem;

// Extendable Silent Rules
%expandableRowArrow {
Expand Down Expand Up @@ -151,6 +152,43 @@ table.withExpColumnShadow tr > *:first-child {
}
}

.indicatorIcon {
display: inline-block;
position: relative;
border: none;
background: none;
padding: 0;
text-align: center;
padding: 0.25rem;
margin: 0.025rem;
width: 1.5rem;
height: 1.5rem;
cursor: pointer;
svg {
fill: $icon-color;
}
}

.indicatorCount {
position: absolute;
bottom: 3px;
right: -2px;
font-weight: bold;
background-color: $indicator-badge-background;
color: $indicator-badge-foreground;
border-radius: 100%;
width: $badge-size;
height: $badge-size;
line-height: $badge-size;
text-align: center;
vertical-align: middle;
font-size: 0.5rem;

&[aria-label='0'] {
display: none;
}
}

.cellContents {
overflow: hidden;
text-overflow: ellipsis;
Expand Down Expand Up @@ -876,51 +914,10 @@ thead {
text-align: left;
}

$badge-size: 0.85rem;

.indicatorIcon {
display: inline-block;
position: relative;
border: none;
background: none;
padding: 0;
text-align: center;
padding: 0.25rem;
margin: 0.025rem;
width: 1.5rem;
height: 1.5rem;
cursor: pointer;
svg {
fill: $icon-color;
}
}

.indicatorCount {
position: absolute;
bottom: 3px;
right: -2px;
font-weight: bold;
background-color: $indicator-badge-background;
color: $indicator-badge-foreground;
border-radius: 100%;
width: $badge-size;
height: $badge-size;
line-height: $badge-size;
text-align: center;
vertical-align: middle;
font-size: 0.5rem;
}

.cellTooltip {
padding: 2px 6px;
}

.indicatorCount {
&[aria-label='0'] {
display: none;
}
}

.experimentCell {
&::before {
content: '';
Expand Down