Update view/title commands to account for VS Code change
#2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
changed the title
view/title commands to account for VS Code change
julieg18
approved these changes
Sep 21, 2022
sroy3
approved these changes
Sep 21, 2022
🤦🏻 this change is only available in Insiders until the next VS Code release... probably the most important thing to mention in the descriptions, sorry! |
|
Code Climate has analyzed commit 21716c6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 85.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 97.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accounts for this VS Code change: microsoft/vscode#42903.
A tree's
view/titlecommands will now be called with the selected item for the context object. This means that if the user is working with a multi-project workspace they will be able to bypass project selection in a tree'sview/titlecommand by selecting the project's root before clicking on the title's command. We previously had one or two of these commands inline for the root but we can now drop that behaviour.Demo
default behaviour (quick pick shown):
Screen.Recording.2022-09-21.at.8.43.49.pm.mov
with root selected (project auto-selected for command):
Screen.Recording.2022-09-21.at.8.35.58.pm.mov