-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass --single option to cloud runners #103
Conversation
@0x2b3bfa0 is our wait mechanism aware of the error is going to throw if the runner is already in use? |
Another issue is that we need to deploy the machine before knowing this. We cant do anything else now but we should add a ticket as a technical debt. |
@DavidGOrtega, we're running the uniqueness checks on the |
@0x2b3bfa0 thats what I say. Right now would be a big effort change so would be better to make a ticket for that change just only to avoid spin a machine. My concern right now is if the runner fails we are logging this correctly in the provider like the await does. |
@DavidGOrtega, I suspect that we've unadvertently mixed up If the runner fails and emits the JSON line we're expecting, the behavior should be similar to any other failure case. 🤔 Is that what you mean? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request passes the newly introduced
--single
option to the launched cloud runners.Closes #94, required by iterative/cml#476