Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --single option to cloud runners #103

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Apr 14, 2021

This pull request passes the newly introduced --single option to the launched cloud runners.

Closes #94, required by iterative/cml#476

@0x2b3bfa0 0x2b3bfa0 self-assigned this Apr 14, 2021
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review April 14, 2021 17:02
@DavidGOrtega DavidGOrtega changed the base branch from master to release/v0.6.1 April 15, 2021 10:14
@DavidGOrtega
Copy link
Contributor

@0x2b3bfa0 is our wait mechanism aware of the error is going to throw if the runner is already in use?

@DavidGOrtega
Copy link
Contributor

Another issue is that we need to deploy the machine before knowing this. We cant do anything else now but we should add a ticket as a technical debt.
Ne able to check single without launching the machine.

@0x2b3bfa0
Copy link
Member Author

@DavidGOrtega, we're running the uniqueness checks on the cml-runner side. Should we move them so they run on the instance?

@DavidGOrtega
Copy link
Contributor

@0x2b3bfa0 thats what I say. Right now would be a big effort change so would be better to make a ticket for that change just only to avoid spin a machine.

My concern right now is if the runner fails we are logging this correctly in the provider like the await does.

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Apr 26, 2021

@DavidGOrtega, I suspect that we've unadvertently mixed up --single and --reuse in the previous comments after reading #94. The former argument is being passed to the cml-runner process on the cloud instance (as per this pull request), while the latter is being handled locally on the original non-cloud invocation.

If the runner fails and emits the JSON line we're expecting, the behavior should be similar to any other failure case. 🤔 Is that what you mean?

Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0x2b3bfa0 0x2b3bfa0 merged commit 799b2d1 into release/v0.6.1 Apr 29, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the add-single-option branch April 29, 2021 12:18
0x2b3bfa0 added a commit that referenced this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing access to runner parameters --reuse --single
2 participants