Unclear failure mode with "undefined" version

[PeterJCLaw]

I'm not completely sure what failed, however one a couple a few of our CI runs just failed on this action with:

Installing DVC from: https://dvc.org/download/linux-deb/dvc-undefined
DVC Download Failed, trying from GitHub Releases
Installing DVC from: https://github.com/iterative/dvc/releases/download/undefined/dvc_undefined_amd64.deb

A retry of the same run shortly afterwards succeeded.

My guess is that the logic to determine the version number failed, however did so in a manner which wasn't immediately an error. Perhaps if the version number lookup fails it should error immediately?

[shcheklein]

hey, thanks for the repo. Yep, it seems that it was not able to determine the version. Does it happen often?

[PeterJCLaw]

I hadn't seen it before this afternoon, though I've now seen it twice.

[shcheklein]

Hmm. Hard to tell what's going on atm. It is relying on the https://updater.dvc.org/ service. And it's working fine (I think it's AWS lambda underneath it). Let's observe it for a bit, and if see this again - please let us know.

[PeterJCLaw]

Are there any debug flags I could turn on in our CI which might yield more information?
For example, perhaps it would be useful to know if the error is in failing to talk to that service or whether that service is returning unexpected (but valid looking) results?

Edit: looks like not, based on reading the action.yml.

[shcheklein]

Yes, I also don't see it. Here is the method I would assume that is getting the latest version id:

https://github.com/iterative/setup-dvc/blob/v1/src/utils.js#L35-L41

[PeterJCLaw]

Hrm, there's no checking there of the HTTP status code. I'm not an expert on fetch though -- is that checked automatically and converted to an error? (Otherwise if the response was either empty json (perhaps {}) or an HTTP 4xx or 5xx then presumably the undefined error would be the outcome)

[PeterJCLaw]

Looks like HTTP status codes are not considered exceptions and need explicit handling (via https://www.npmjs.com/package/node-fetch#handling-exceptions)

[shcheklein]

Yep, we would be happy to accept a quick PR and release if you have time for this.

[PeterJCLaw]

FWIW, I don't think I've seen this since the spate of occurrences around the time I raised this issue.