fix(chart-testing): Fix helm-chart testing workflow #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjasion
force-pushed
the
fix_github_workflow
branch
from
cd7c659 to
b0471b8
Compare
- Add hidden variable `ci` which removes annotations and creates docker config - Add hidden variables to pass docker user, password and server
mjasion
force-pushed
the
fix_github_workflow
branch
from
b0471b8 to
511d79b
Compare
jesper7
reviewed
Jul 7, 2023
| @@ -0,0 +1,9 @@ | |||
| {{- if (hasKey .Values "ci") }} | |||
There was a problem hiding this comment.
Can we add a comment saying that this file is only used in the CI workflow?
Also, maybe rename the file to ci-secret-docker-registry.yaml
mjasion
force-pushed
the
fix_github_workflow
branch
2 times, most recently
from
2f6bf9a to
1ec3645
Compare
Co-authored-by: Jesper Svendsen <99078145+jesper7@users.noreply.github.com>
mjasion
force-pushed
the
fix_github_workflow
branch
from
1ec3645 to
312ee1e
Compare
0x2b3bfa0
approved these changes
Jul 10, 2023
mjasion
commented
Jul 12, 2023
| {{- if (hasKey .Values "ci") }} | ||
| apiVersion: v1 | ||
| data: | ||
| .dockerconfigjson: {{ include "dockerconfig" . | b64enc | quote }} |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ciwhich removes annotations and creates docker config secretIf this fix will work, we will have reliable install and upgrade test process :-)
Fixes https://github.com/iterative/itops/issues/1903