build: pyinstaller: use __pyinstaller #9680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
pyinstaller-hook
branch
2 times, most recently
from
20f13ee to
0c2d099
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #9680 +/- ##
==========================================
- Coverage 90.62% 90.23% -0.40%
==========================================
Files 472 479 +7
Lines 36283 36309 +26
Branches 5218 5219 +1
==========================================
- Hits 32883 32762 -121
- Misses 2814 2931 +117
- Partials 586 616 +30
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern way of including pyinstaller hooks into the package itself.
Overall kinda cosmetic, but with dvc-osxpkg/exe/s3-repo having their own build/sign process we won't be able to use
scripts/pyinstalleranymore.Similar to iterative/PyDrive2#243