Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): Bump mypy from 0.982 to 0.990 #8535

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 8, 2022

Bumps mypy from 0.982 to 0.990.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 94.31% // Head: 94.31% // No change to project coverage 👍

Coverage data is based on head (65f763f) compared to base (e9c5b5f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8535   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files         430      430           
  Lines       32830    32830           
  Branches     4581     4581           
=======================================
  Hits        30963    30963           
  Misses       1449     1449           
  Partials      418      418           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dependabot bot and others added 2 commits November 11, 2022 13:45
Bumps [mypy](https://github.com/python/mypy) from 0.982 to 0.990.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.982...v0.990)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@pmrowla
Copy link
Contributor

pmrowla commented Nov 11, 2022

mypy 0.990 now enforces PEP484 and disallows implicit Optional usage by default (i.e. def func(foo: int = None)) is disallowed by PEP484. We use this pattern a lot (especially in older untyped or partially typed parts of DVC), so mypy is now configured to allow this usage in DVC, but we should try to use the correct pattern going forward (foo: Optional[int] = None)

see also: python/mypy#9091

@pmrowla pmrowla enabled auto-merge (rebase) November 11, 2022 04:58
@pmrowla pmrowla merged commit 8913f5a into main Nov 11, 2022
@pmrowla pmrowla deleted the dependabot/pip/mypy-0.990 branch November 11, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant