logger: log datetime when on debug mode #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Feb 14, 2020
|
|
||
| return "{color}{date}{nc} ".format( | ||
| color=colorama.Fore.GREEN, | ||
| date=super().formatTime(record, datefmt), |
There was a problem hiding this comment.
The default output looks like 2020-02-14 17:13:44,627. I did not really tried fighting with the format and went with default one. Plus, this supports setting datefmt from dictConfig.
There was a problem hiding this comment.
If we need a different format later on, we can just change in the dictConfig anyway. 🙂
There was a problem hiding this comment.
Yeah, a bit long for my taste. We could shorten stuff like year (cut it off or shorten to "20"), but it won't make a big deal. I'm ok with leaving it as is. 👍
Also, really like the implementation 😉
pared
reviewed
Feb 17, 2020
| "red": colorama.Fore.RED, | ||
| "yellow": colorama.Fore.YELLOW, | ||
| "nc": colorama.Fore.RESET, | ||
| } | ||
|
|
||
|
|
||
| @pytest.fixture() | ||
| def dt(mocker): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fixes #3282