logger: allow exc_info in all record types #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
efiop
commented
Feb 9, 2020
| @@ -51,37 +51,29 @@ class ColorFormatter(logging.Formatter): | |||
|
|
|||
| color_code = { | |||
| "DEBUG": colorama.Fore.BLUE, | |||
| "INFO": "", | |||
efiop
commented
Feb 9, 2020
| "WARNING": colorama.Fore.YELLOW, | ||
| "ERROR": colorama.Fore.RED, | ||
| "CRITICAL": colorama.Fore.RED, | ||
| } | ||
|
|
||
| def format(self, record): | ||
| msg = record.msg.format(*record.args) if record.args else record.msg | ||
| exception, stack_trace = self._parse_exc(record) |
There was a problem hiding this comment.
docstring said that exc_info is accounted for, but it wasn't unless record was at ERROR or CRITICAL levels.
efiop
changed the title
This better reflects the original logger formatter. This also fixes annoying redundant newline between traceback and "need any help" footer.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This better reflects the original logger formatter and is neede for further improvements in the following PRs.
This also fixes annoying redundant newline between traceback and "need
any help" footer.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏