Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Privacy Policy with used Google scopes #954

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Extend Privacy Policy with used Google scopes #954

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b4261c
Extend Privacy Policy with used Google scopes
maxhora Jan 28, 2020
54aa80a
Privacy Policy: mention drive.appdata scope.
maxhora Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions public/static/docs/user-guide/privacy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ section of this User Guide.

## Scopes

userinfo.email scope (view your email address), userinfo.profile scope (see your
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use userinfo.email (inline code) blocks for scope names to make a bit more readable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shcheklein have updated markup and have added mention about drive.appdata scope as well.
Not sure why CicrcleCI won't start (how it might be related to my GitHub account).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maxris don't worry about this for now. Have asked their support to check what the issue could be.

personal info, including any personal info you've made publicly available), and
openid scope (authenticate using OpenID Connect) are required to be used by
Google Auth. DVC authorizes users via
[Google's server](https://accounts.google.com/o/oauth2/auth) and doesn't access
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This link doesn't work like this. Should we just display it instead like `https://accounts.google.com/o/oauth2/auth` ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jorgeorpinel , the idea here was to mention explicitly that server belongs to Google and link was added just as a prove. Also link might change with time.

Copy link
Contributor Author

@maxhora maxhora Feb 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not sure why it doesn't work? I can click at "Google's server" text and the URL is opened in new tab ( error in new tab is displayed, but it is fine )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @jorgeorpinel refers to the fact that it returns 404 and looks like broken bc of that. Also trigger our CI scripts that detect broken/dead links. I've added it to the exclusion list for now. Still, not clear if it makes sense to keep it this way, even though I understand the intention.

Copy link
Contributor

@jorgeorpinel jorgeorpinel Feb 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we need it in the link exclusion list anyway, but it's best to display the link in the markdown like a `quote` instead of a clickable link, I think.

And yes, I meant it's not a link to any useful website. It doesn't work like that = it's not meant to be navigated, just the base URL to begin a OAuth authentication (but needs a special token in the URL query)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel got it, thanks, should I propose the changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel let's fix it as part of the regular updates flow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 45e93dc. I reorganized and reworded some paragraphs along the way so please review the draft PR (#987).

or collect users data used by Google Auth.

DVC allows you to manage your Google Drive files and therefore the default
scopes include read/write access to Google Drive.

Expand Down