regular updates and fixes (early September) #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeorpinel
commented
Sep 1, 2019
…-reference/gc.md (using i/[^`]DVC / regex) for #448
shcheklein
reviewed
Sep 2, 2019
This comment has been minimized.
This comment has been minimized.
shcheklein
reviewed
Sep 2, 2019
shcheklein
reviewed
Sep 2, 2019
shcheklein
reviewed
Sep 4, 2019
shcheklein
reviewed
Sep 4, 2019
|
Sorry for the delay here @shcheklein. I was a bit stuck in a bunch of other discussions and trying to finish all of #448 here... So many file changes... Sry 😅 |
|
p.s. I'm done adding commits here. Maybe one more involving the term "project metrics" but that can always go into a future PR. |
shcheklein
reviewed
Sep 6, 2019
| @@ -166,7 +166,7 @@ $ tree | |||
| ├── count.txt <---- result: "2" | |||
| ├── filter.dvc <---- first stage | |||
| ├── numbers.txt <---- intermediate result of the first stage | |||
| ├── process.py <---- code that runs some transformation | |||
| ├── process.py <---- code that causes data transformation | |||
There was a problem hiding this comment.
causes is not the best term either. If we want to change this we can use implements for example or even simple does.
There was a problem hiding this comment.
I see you've fixed this already (: Thanks
shcheklein
approved these changes
Sep 6, 2019
|
huge stuff :) congrats 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #448, and brings other ad hoc changes.