Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: main exp workflow (run,show,diff,apply) #2200

Merged
merged 40 commits into from
Mar 3, 2021
Merged

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Feb 17, 2021

Splits and improves #1926

  • exp run/show/diff/apply Descs and Options
  • related updates to the guides and other refs (index and API)

I left out the examples in this PR b/c it's getting too big.

@shcheklein shcheklein temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk February 17, 2021 02:16 Inactive
@jorgeorpinel jorgeorpinel changed the title ref: exp run,show,apply ref: main exp workflow (run,show,apply) Feb 17, 2021
Comment on lines +220 to +225
"source": "exp/index.md",
"children": [
{
"label": "exp run",
"slug": "run"
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiii @rogermparent another quick callout... Would it be possible to automatically label subcommands inside children as parent children to avoid all these {} structures (here and in other subcommand groups). Ty

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like replacing { "label": "exp run", "slug": "run" } with the string "run" having the same effect? That's a good idea, and totally doable!

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I was just thinking to replace the whole {} block with "run" in this case Yep, exactly (:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any hope we can get that done for this PR @rogermparent? No worries if not but let's make make an issue then? Thanks

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk February 17, 2021 17:25 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk February 17, 2021 20:19 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk February 18, 2021 00:39 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk February 22, 2021 06:06 Inactive
@jorgeorpinel jorgeorpinel had a problem deploying to dvc-org-ref-exp-main-rbzbwyywk February 22, 2021 06:06 Failure
@jorgeorpinel jorgeorpinel changed the base branch from ref/experiments to master February 23, 2021 21:56
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk February 28, 2021 23:33 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk March 1, 2021 00:37 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk March 1, 2021 01:08 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk March 1, 2021 01:29 Inactive
@jorgeorpinel jorgeorpinel force-pushed the ref/exp/main branch 2 times, most recently from 59412a9 to a16d83e Compare March 1, 2021 01:31
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk March 1, 2021 01:31 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Mar 1, 2021

LGTM @shcheklein @dberenbaum @pmrowla ? Examples will be coming in a separate PR (this one is large enough). The remaining commands also have their own PR (#2243).

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk March 1, 2021 06:45 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk March 1, 2021 06:53 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk March 1, 2021 08:01 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk March 1, 2021 08:09 Inactive
Copy link
Collaborator

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-main-rbzbwyywk March 2, 2021 17:38 Inactive
@jorgeorpinel
Copy link
Contributor Author

OK guys I'm going to merge this. There will be more iterations in case anyone has more comments. Thanks!

@jorgeorpinel jorgeorpinel merged commit 7c21a9a into master Mar 3, 2021
@jorgeorpinel jorgeorpinel mentioned this pull request Mar 3, 2021
1 task
@jorgeorpinel jorgeorpinel deleted the ref/exp/main branch March 10, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants