Fix for reading exported parquet #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
e560b08
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e36e01c3.datachain-documentation.pages.dev |
| Branch Preview URL: | https://ilongin-1066-fix-reading-exp.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
=======================================
Coverage 88.68% 88.69%
=======================================
Files 152 152
Lines 13606 13609 +3
Branches 1893 1894 +1
=======================================
+ Hits 12067 12070 +3
Misses 1093 1093
Partials 446 446
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Make sense, I've overwritten it now with new source. |
shcheklein
reviewed
May 19, 2025
src/datachain/lib/arrow.py
Outdated
| if self.output_schema and hasattr(vals[0], "source"): | ||
| # if we are reading parquet file written by datachain it might have | ||
| # source inside of it already, so we should not duplicate it, instead | ||
| # we are re-creating it |
There was a problem hiding this comment.
cleanup the comment a bit ... (no extra line is needed)
There was a problem hiding this comment.
let's also add to docs (source=True) - that if it enabled and the file already has it - it will be rewritten (e.g. when file was generated by datachain before)
|
@ilongin what is the status here? |
Co-authored-by: Vladimir Rudnykh <dreadatour@gmail.com>
Co-authored-by: Vladimir Rudnykh <dreadatour@gmail.com>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue when we read parquet file that is being created with datachain itself and already has source fields inside it. What was happening is that we were adding duplicated source fields on read and this PR avoids that even if
source=Trueflag is set.