Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and fix merge mistake #745

Merged
merged 3 commits into from
Sep 24, 2021
Merged

Update dependencies and fix merge mistake #745

merged 3 commits into from
Sep 24, 2021

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Sep 24, 2021 •
edited
Loading

npm audit fix && npm upgrade and install missing peer dependency (@octokit/core) so npm stops complaining

Additionally, fixes a merge mistake that interleaved deprecated identifiers with the new code

@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 24, 2021
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 24, 2021 10:43 Inactive
casperdcl
casperdcl approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beat me to it by a few min :)

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 24, 2021 10:47 Inactive
@0x2b3bfa0 0x2b3bfa0 changed the title Update dependencies Update dependencies and fix merge mistake Sep 24, 2021
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 24, 2021 10:52 Inactive
@0x2b3bfa0 0x2b3bfa0 merged commit c5e9e3b into master Sep 24, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the update-packages branch September 24, 2021 11:34
@casperdcl casperdcl added the releases Shipping builds label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

@DavidGOrtega DavidGOrtega Awaiting requested review from DavidGOrtega

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
releases Shipping builds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x2b3bfa0 @casperdcl