Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runner status log reporting #731

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Fix runner status log reporting #731

merged 2 commits into from
Sep 22, 2021

Conversation

0x2b3bfa0
Copy link
Member

Missing the blunder label

@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working p0-critical Max priority (ASAP) labels Sep 22, 2021
@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 22, 2021
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 22, 2021 09:36 Inactive
bin/cml/runner.js Outdated Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 22, 2021 09:38 Inactive
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@0x2b3bfa0 0x2b3bfa0 merged commit 30d754c into master Sep 22, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the fix-release-bugs branch September 22, 2021 09:40
@0x2b3bfa0
Copy link
Member Author

Explanation

Winston, the logging library introduced with #703, only outputs plain text on interactive environments. When the standard output is not a TTY, it will output plain JSONL logs instead.

cml/bin/cml.js

Lines 12 to 17 in 7d664ae

format: process.stdout.isTTY
? winston.format.combine(
winston.format.colorize({ all: true }),
winston.format.simple()
)
: winston.format.json(),

The provided winston.debug call was outputting the JSON object as an escaped JSON string embedded in another object, thus causing the Terraform provider to time out waiting for the readiness signal, which was unable to parse.


Not a proper report, but enough to cover the causes. I still have lots of things to do today. 🏃🏼 😅

@casperdcl
Copy link
Contributor

yup

xkcd#844

@0x2b3bfa0
Copy link
Member Author

Cough, cough. Actually, that wasn't supposed to be winston.debug but a plain console.log in the first place; see 8de7c23

@casperdcl
Copy link
Contributor

✈️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0-critical Max priority (ASAP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert remaining console.log and console.error calls to logger calls
3 participants