auth: drop json credentials backend #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
force-pushed
the
drop-json-backend
branch
6 times, most recently
from
b23e7c6 to
819a1e3
Compare
isidentical
commented
Mar 5, 2021
isidentical
force-pushed
the
drop-json-backend
branch
3 times, most recently
from
18a8dd4 to
a9f23d4
Compare
isidentical
commented
Mar 6, 2021
shcheklein
reviewed
Mar 6, 2021
isidentical
force-pushed
the
drop-json-backend
branch
from
a9f23d4 to
846f9fd
Compare
shcheklein
reviewed
Mar 8, 2021
shcheklein
approved these changes
Mar 8, 2021
|
LGTM. feel free to merge! A few minor 💅 that would be great to address to save some time next personal dealing with this. |
shcheklein
reviewed
Mar 8, 2021
isidentical
force-pushed
the
drop-json-backend
branch
from
9cd13fa to
86a4b29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redundantly introduced in #81, and the cause of some downstream issues. Removing per #96