Skip to content

gdrive: remove empty file hack #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020
Merged

gdrive: remove empty file hack #64

merged 1 commit into from
Oct 22, 2020

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Oct 21, 2020

googleapis/google-api-python-client#1070 is now
merged, so we can get rid of our hack
#48

Fixes #59

@efiop
Copy link
Contributor Author

efiop commented Oct 21, 2020

Ok, upload works great now, but download still fails with 416, waiting for devs to respond in googleapis/google-api-python-client#638 (comment)

@efiop
Copy link
Contributor Author

efiop commented Oct 22, 2020

Ok, api should be fixed now googleapis/google-api-python-client#1074 . Waiting for a new release and will update this PR.

@efiop efiop force-pushed the fix-59 branch 2 times, most recently from 68672ed to 0b60592 Compare October 22, 2020 15:28
@efiop
Copy link
Contributor Author

efiop commented Oct 22, 2020

Yep, fixed now.

@efiop efiop changed the title [WIP] gdrive: remove empty file hack gdrive: remove empty file hack Oct 22, 2020
@efiop efiop merged commit f0dd362 into master Oct 22, 2020
@shcheklein shcheklein deleted the fix-59 branch November 15, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle downloading/uploading empty files
1 participant