Skip to content

fix/256(fsspec): size can be None for drive files #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2023
Merged

fix/256(fsspec): size can be None for drive files #257

merged 1 commit into from
Feb 20, 2023

Conversation

shcheklein
Copy link
Member

@shcheklein shcheklein commented Feb 19, 2023 •
edited
Loading

Fixes #256

Some files (I think older Google docs, sheets, etc - prior to ~May 2022) don't have size fields. This enables compatibility with these files.

@shcheklein shcheklein added the bug Something isn't working label Feb 19, 2023
@shcheklein shcheklein self-assigned this Feb 19, 2023
@shcheklein shcheklein temporarily deployed to internal February 19, 2023 18:07 — with GitHub Actions Inactive
@shcheklein shcheklein requested a review from efiop February 19, 2023 18:33
efiop
efiop reviewed Feb 19, 2023
View reviewed changes
@shcheklein shcheklein temporarily deployed to internal February 19, 2023 19:38 — with GitHub Actions Inactive
@shcheklein shcheklein requested a review from efiop February 19, 2023 19:38
efiop
efiop approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@efiop efiop merged commit 9307211 into main Feb 20, 2023
@efiop efiop deleted the fix-256 branch February 20, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

Assignees

@shcheklein shcheklein

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GoogleDriveFile handle files with no fileSize
2 participants
@shcheklein @efiop