pyinstaller: fix CI on py<3.10 #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
approved these changes
Nov 15, 2022
pmrowla
commented
Nov 15, 2022
Comment on lines
+8
to
+15
| if sys.version_info >= (3, 10): | ||
| from importlib.resources import contents | ||
| else: | ||
| from importlib_resources import contents |
There was a problem hiding this comment.
importlib.resources.contents is already available in 3.7+, but due to the way pyinstaller handles importlib, we have to use the importlib_resources backport version on <3.10 for this test
There was a problem hiding this comment.
@pmrowla Would it be worth putting a comment there?
There was a problem hiding this comment.
I'll wait and see if this CI run passes and then add the comment before merging
pmrowla
force-pushed
the
fix-pyinstaller-3.10
branch
from
25fead5 to
11aa9de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.