fs: add acknowledge_abuse parameter #214
Conversation
| Files identified as `abusive`_ (malware, etc.) are only downloadable by the owner. | ||
| If you see a | ||
| 'This file has been identified as malware or spam and cannot be downloaded' | ||
| error, set 'acknowledge_abuse=True' parameter in `GetContentFile()`. By using |
There was a problem hiding this comment.
Decided not to add this flag to GetContentString for now because it is tiny bit more involved and we have no use for it anyway.
Also didn't add GetContentIOBuffer to this doc, because it is not documented at all yet 🙁
There was a problem hiding this comment.
There was a problem hiding this comment.
@shcheklein I suppose you meant v2 https://developers.google.com/drive/api/v2/reference/files/get#acknowledgeAbuse . But I'm not sure how useful that is, who cares what we use internally.
| @@ -167,6 +167,7 @@ def __init__( | |||
| client_json_file_path=None, | |||
| use_service_account=False, | |||
| profile=None, | |||
| acknowledge_abuse=False, | |||
There was a problem hiding this comment.
style/minor - move trash only nearby to this one
There was a problem hiding this comment.
Strictly speaking, that would be breaking backwards compatibility. But we can add an *args guard (which is also breaking it but at least only once).
There was a problem hiding this comment.
Introducing the guard forces changing tests, which is out of scope here. Can get back to this separately in a followup. For now moved those flags nearby, as requested.
Related #62 Pre-requisite for iterative/dvc#7832
|
Happy to address any small things on top. |
Related #62
Pre-requisite for iterative/dvc#7832