fs: simplify auth #211
Merged
fs: simplify auth #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Jul 19, 2022
shcheklein
reviewed
Jul 19, 2022
shcheklein
reviewed
Jul 19, 2022
shcheklein
reviewed
Jul 19, 2022
shcheklein
reviewed
Jul 19, 2022
shcheklein
reviewed
Jul 19, 2022
efiop
commented
Jul 20, 2022
|
@shcheklein Should be alright for now. Please take a look when you'll have time. |
Compared to how we were using it in dvc before:
1) doesn't require/accept `tmp_dir` at all, caches creds in
`appdirs("pydrive2fs", appauthor=False)`.
2) caching is per `client_id`, so no risk of using mismatched client_id and
cached creds. If user supplies a `profile`(defaults to `default`) - we'll
also cache it by `profile` to support multiple google users using the same
`client_id`.
3) renamed `service_account_json_file_path` into `client_json_file_path` for
consistency.
4) renamed `service_account_user_email` into `client_user_email` for
consistency.
Other than that, this is mostly old code.
Fixes #193
shcheklein
approved these changes
Jul 20, 2022
efiop
added a commit
to efiop/dvc
that referenced
this pull request
Feb 16, 2023
We used to use it in gdrive before iterative/PyDrive2#211
efiop
added a commit
to efiop/dvc
that referenced
this pull request
Feb 16, 2023
We used to use it in gdrive before iterative/PyDrive2#211
efiop
added a commit
to iterative/dvc
that referenced
this pull request
Feb 16, 2023
We used to use it in gdrive before iterative/PyDrive2#211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to how we were using it in dvc before:
tmp_dirat all, caches creds inappdirs("pydrive2fs", appauthor=False).client_id, so no risk of using mismatched client_id andcached creds. If user supplies a
profile(defaults todefault) - we'llalso cache it by
profileto support multiple google users using the sameclient_id.service_account_json_file_pathintoclient_json_file_pathforconsistency.
service_account_user_emailintoclient_user_emailforconsistency.
Other than that, this is mostly old code.
Fixes #193