auth: service: don't forget to load json configs #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
approved these changes
Jul 19, 2022
efiop
commented
Jul 19, 2022
Comment on lines
586
to
588
| if value: | ||
| self.client_config[config] = value | ||
| break |
There was a problem hiding this comment.
We can probably transfer all of the options instead of trying to pick the first best one (we will do that later in ServiceAuth anyway). But keeping similar to how it was before for now.
efiop
changed the title
efiop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
client_user_emailis not specified - it will triggerLoadServiceConfigSettingscall duringServiceAuth, which will raise an exception because it doesn't see neitherjsonnorpkcs12keyfile path.