Skip to content

auth: add client_creds_dict #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2022
Merged

auth: add client_creds_dict #202

merged 1 commit into from
Jul 17, 2022

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jul 17, 2022

This allows programmatic use without having to create a temporary file.

This allows programmatic use without having to create a temporary file.
@efiop
Copy link
Contributor Author

efiop commented Jul 17, 2022

From what I can see GoogleAuth requires settings file, which is how tests operate https://github.com/iterative/PyDrive2/blob/master/pydrive2/test/test_oauth.py And there is no support for providing settings through a dict, which makes testing this extremely hard without doing awful things like modifying GoogleAuth.DEFAULT_SETTINGS (which we do when using in dvc 🙁 ).

@efiop efiop merged commit ad7e726 into master Jul 17, 2022
@efiop efiop deleted the auth branch July 17, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant