-
Notifications
You must be signed in to change notification settings - Fork 72
ci: add test/pre-commit actions #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
901d0ad
to
97b3e40
Compare
It is extremely weird that tests constantly stuck and timeout. Last night it got timeout at %83 percent after 6 hours and today even though locally everything works fine they still time out. I also tried to add |
Yeah, this is odd. They took 4m on travis, so something is going on here. Is it some particular test that hangs? |
After 60 minutes, these are the results;
|
This is the test collection for the reference; $ pytest --collect-only
============================================================================== test session starts ===============================================================================
platform linux -- Python 3.8.5+, pytest-6.2.4, py-1.9.0, pluggy-0.13.1
rootdir: /home/isidentical/PyDrive2, configfile: pytest.ini
plugins: timeout-1.4.2, mock-3.6.1, lazy-fixture-0.6.3, anyio-2.0.2, tap-3.2, env-0.6.2, cov-2.12.1, flaky-3.7.0, xdist-2.3.0, docker-0.10.3, apiritif-0.9.8, forked-1.3.0, asyncio-0.14.0
collected 47 items
<Package test>
<Module test_apiattr.py>
<UnitTestCase ApiAttributeTest>
<TestCaseFunction test_UpdateMetadataNotInfinitelyNesting>
<Module test_drive.py>
<UnitTestCase GoogleDriveTest>
<TestCaseFunction test_01_About_Request>
<Module test_file.py>
<UnitTestCase GoogleDriveFileTest>
<TestCaseFunction test_01_Files_Insert>
<TestCaseFunction test_02_Files_Insert_Unicode>
<TestCaseFunction test_03_Files_Insert_Content_String>
<TestCaseFunction test_04_Files_Insert_Content_Unicode_String>
<TestCaseFunction test_05_Files_Insert_Content_File>
<TestCaseFunction test_06_Files_Patch>
<TestCaseFunction test_07_Files_Patch_Skipping_Content>
<TestCaseFunction test_08_Files_Update_String>
<TestCaseFunction test_09_Files_Update_File>
<TestCaseFunction test_10_Files_Download_Service>
<TestCaseFunction test_11_Files_Get_Content_Buffer>
<TestCaseFunction test_12_Upload_Download_Empty_File>
<TestCaseFunction test_13_Upload_Download_Empty_String>
<TestCaseFunction test_ApiRequestError_HttpError_Propagation>
<TestCaseFunction test_Files_Delete_File>
<TestCaseFunction test_Files_Delete_File_Just_ID>
<TestCaseFunction test_Files_Delete_Permission>
<TestCaseFunction test_Files_Delete_Permission_Invalid>
<TestCaseFunction test_Files_FetchAllMetadata_Fields>
<TestCaseFunction test_Files_FetchMetadata_Fields>
<TestCaseFunction test_Files_Get_Permissions>
<TestCaseFunction test_Files_Insert_Permission>
<TestCaseFunction test_Files_Trash_File>
<TestCaseFunction test_Files_Trash_File_Just_ID>
<TestCaseFunction test_Files_UnTrash_File>
<TestCaseFunction test_Files_UnTrash_File_Just_ID>
<TestCaseFunction test_GFile_Conversion_Lossless_String>
<TestCaseFunction test_GFile_Conversion_Remove_BOM>
<TestCaseFunction test_Gfile_Conversion_Add_Remove_BOM>
<TestCaseFunction test_InsertPrefix>
<TestCaseFunction test_InsertPrefixLarge>
<TestCaseFunction test_Parallel_Insert_File_Passed_HTTP>
<TestCaseFunction test_RemovePrefix>
<TestCaseFunction test_RemovePrefixLarge>
<Module test_filelist.py>
<UnitTestCase GoogleDriveFileListTest>
<TestCaseFunction test_01_Files_List_GetList>
<TestCaseFunction test_02_Files_List_ForLoop>
<TestCaseFunction test_03_Files_List_GetList_Iterate>
<TestCaseFunction test_File_List_Folders>
<Module test_oauth.py>
<UnitTestCase GoogleAuthTest>
<TestCaseFunction test_01_LocalWebserverAuthWithClientConfigFromFile>
<TestCaseFunction test_02_LocalWebserverAuthWithClientConfigFromSettings>
<TestCaseFunction test_03_LocalWebServerAuthWithNoCredentialsSaving>
<TestCaseFunction test_04_CommandLineAuthWithClientConfigFromFile>
<TestCaseFunction test_05_ConfigFromSettingsWithoutOauthScope>
<TestCaseFunction test_06_ServiceAuthFromSavedCredentialsP12File>
<TestCaseFunction test_07_ServiceAuthFromSavedCredentialsJsonFile>
========================================================================== 47 tests collected in 0.99s =========================================================================== |
97b3e40
to
3b720bf
Compare
Seems like I missed the |
8013807
to
ec29ba1
Compare
ec29ba1
to
4c26a0f
Compare
We are hitting the limits again :( And not clear why, right? ... like the last time ... @efiop could you remind please what was the final answer from them? Should we for the sake of simplicity for now run all the tasks sequentially? Also, reduce number of those - e.g. sacrifice Python 3.6 |
Looks like we've been merging and releasing broken builds for awhile now https://github.com/iterative/PyDrive2/pulls?q=is%3Apr+is%3Aclosed 🙁 So yeah, let's reduce the tests here for now, and get back to researching this in more detail in a follow-up. |
@shcheklein I have yet to take a closer look there, unfortunately 🙁 Looks like we've been failing for awhile though, so I've just reduced testing to 1 linux job for now, and created a ticket to take a closer look at rate limits (left 3.6 because it is the easiest to break with backward incompatible python/fsspec shenanigans). |
Makes sense.
Is there a way to run the matrix sequentially? That would solve the problem w/o sacrificing Win/Mac. Or specify level of parallelism. No, I don't think we were releasing a broken version, btw - https://github.com/iterative/PyDrive2/runs/2730348445 . It might be we were merging (if the problem was due to rate limits or some travis issues), but I was waiting for tests to pass for the release I think. |
@shcheklein Yeah, there are some tricks to do that. Will try it out in a follow-up. |
Resolves #120