Feature: Client credential authentication for configuration download #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twwd
requested changes
Dec 13, 2024
Convert asserts to raised ValueErrors, use f-strings, etc.
twwd
force-pushed
the
feature/client-credential-auth
branch
from
2fcafc6 to
2c00b70
Compare
twwd
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we can only use password-based authentication to download the configuration from Keycloak. This PR adds functionality to use a service account with the relevant permissions to perform the config dump.
As a bonus, it also allows choosing a different client, including confidential clients, for password-based authentication. This is useful if you want to switch to a confidential client to avoid having a public client with direct access grants enabled (i.e., something that kcwarden itself would complain about 😉).
See the updated documentation for usage information.
Closes #55.